[patch] small lexer changes
Mark M. Hoffman
mhoffman at lightlink.com
Tue Oct 8 03:13:14 CEST 2002
* Matthias Andree <matthias.andree at gmx.de> [2002-10-07 22:24:41 +0200]:
> On Mon, 07 Oct 2002, Mark M. Hoffman wrote:
>
> > 1. Tighten specification for IP addresses.
>
> If you want it really tight, how about something along these lines:
>
> INT8: ([01]?[0-9]?[0-9]|2([0-4][0-9]|5[0-5]))
> IPADDR: {INT8}\.{INT8}\.{INT8}\.{INT8}
Yes this is better, thanks.
> > 2. Ignore ESMTP ids (in addition to SMTP ids)
> > 3. Fix lexertest interface to lexer bug, which matters not now
> > but will later.
>
> These are fine with me, I hacked this up pretty quick and I'm not really
> aware of [f]lex interfaces.
No problem... I introduced the bug myself (by omission) when I changed
the interface to yylval in the first place.
> I'm just wondering if we could reduce the lexer.c code size without
> sacrificing too much speed. lexer.c is >46,000 lines here, which pretty
> much stinks.
See my response in a later email (which I'm about to send...)
Regards,
--
Mark M. Hoffman
mhoffman at lightlink.com
More information about the bogofilter-dev
mailing list