Script Changes [was: bf_compact]

[Matthias Andree]

On Sun, 15 May 2005, David Relson wrote:

> I'm looking at the changes to bf_tar, particularly the expectation that
> the path be absolute.  Surely there's a better way to do this!

Yes, but that would shift your release out by three days. You'd not
be going to like that.

> With the options used in bf_tar, bogoutil is listing file names.
> Surely it can be smarter and prepend the directory name.  This would
> give a consistent set of filenames and we could discard the absolute/
> relative path check.
> 
> However, as stated before I want to limit the changes between 0.94.12
> and 0.94.13 to documentation.  I've not decided yet, but I'm thinking
> of rolling back the bf_tar changes.

The changes document the existing and long-standing bug and add an
additional warning. The user is free to ignore it, and reading the man
page, is instructed of the consequences.

I don't want users surprised by a tarball that lists

.bogofilter/DB_CONFIG
.bogofilter/wordlist.db
/home/hans/.bogofilter/log.0000000023

Unpacking this on a different machine is going to be a pain if the
user has a different name there...

Note: Just removing the "absolute" keyword from the bogoutil call is not
enough, and I bet you're not willing to debug the implications of a
set_lg_dir in DB_CONFIG for 0.94 for the myriads of path relations
possible. Sticking with absolute path for the log files is the safe way
and not a severe limitation. The user can just prepend $(pwd)/ to his
relative path and everything's fine. Perhaps we could have had the
script to that, but I didn't want a last-minute *functional* change.

I'd suggest to leave the script alone and perhaps add the suggestion
with prepending $(pwd)/ to the examples. I've committed a change to
bf_tar.xml.

-- 
Matthias Andree