bogofilter 0.17.2 writing out X-Bogosity header and message separater as LF instead of CRLF

[Jim Correia]

On Feb 24, 2004, at 1:15 PM, Pavel Kankovsky wrote:

> On Mon, 23 Feb 2004, Jim Correia wrote:
>
>> 1) The spam header written in write_message in passthrough.c:260 is LF
>> terminated. Shouldn't it be CRLF terminated like the rest of the
>> headers?
>> 2) In write_body in the same file, it separates the message from the
>> headers with LF LF. Again, shouldn't this be CRLF CRLF?
>
> No & no. Most, if not all, unix MTAs use LF alone to separate lines 
> when
> the mail is stored in a local file (e.g. a BSD mailbox) or fed to a
> local process. CRLF is for SMTP (and, ehm, for certain backward
> platforms).
>
> CRLF might be an option but it should not be the default setting.

Yeah - I did some more digging last night and discovered that at the 
MTA level things are all LF based, so bogofilter was behaving 
correctly.

I sent David private mail re: the patch and reworked my glue code to do 
the transformations before and after the fork (I was working on a 
client side filter where the data uses CRLF network endings on both 
sides of the call to bogofilter.)

- Jim