compile time options

[Matthias Andree]

Boris 'pi' Piwinger <3.14 at logic.univie.ac.at> writes:

>>   --disable-graham-method Disable Graham calculation method
>>   --disable-robinson-method
>>                           Disable Robinson calculation method
>>   --disable-robinson-fisher
>>                           Disable Fisher's method of combining probabilities
>
> Those seem to be most interesting to me, but what could be
> used as FEATURE here:

IMHO, we can just drop Graham's original method. I wonder if we should
drop Robinson's original method; but in either case, we should just drop
these --disable options, they add some baggage to the build system that
isn't important given the total project size -- did someone say "lexer"
:-)

If it makes people ask questions, let's drop it :*)

-- 
Matthias Andree

Encrypt your mail: my GnuPG key ID is 0x052E7D95


Return-Path: <>
Delivered-To: relson at osagesoftware.com
Received: from natmout00.rzone.de (natmout00.rzone.de [81.169.145.163])
	by osagesoftware.com (Postfix) with ESMTP id F167627D86
	for <relson at osagesoftware.com>; Mon, 29 Sep 2003 17:56:57 -0400 (EDT)
Received: from localhost (localhost)
	by mailin.webmailer.de (8.12.10/8.12.10) id h8TL8aKu017950;
	Mon, 29 Sep 2003 23:56:49 +0200 (MEST)
Date: Mon, 29 Sep 2003 23:56:49 +0200 (MEST)
From: Mail Delivery Subsystem <MAILER-DAEMON at post.webmailer.de>
Message-Id: <200309292156.h8TL8aKu017950 at mailin.webmailer.de>
To: <relson at osagesoftware.com>
MIME-Version: 1.0
Content-Type: multipart/report; report-type=delivery-status;
	boundary="h8TL8aKu017950.1064872609/mailin.webmailer.de"
Subject: Warning: could not send message for past 4 hours
Auto-Submitted: auto-generated (warning-timeout)

This is a MIME-encapsulated message

--h8TL8aKu017950.1064872609/mailin.webmailer.de

    **********************************************
    **      THIS IS A WARNING MESSAGE ONLY      **
    **  YOU DO NOT NEED TO RESEND YOUR MESSAGE  **
    **********************************************

The original message was received at Mon, 29 Sep 2003 19:28:17 +0200 (MEST)
from osagesoftware.com [216.144.204.42]

   ----- Transcript of session follows -----
<sbellon at sbellon.de>... Deferred
Warning: message still undelivered after 4 hours
Will keep trying until message is 5 days old

--h8TL8aKu017950.1064872609/mailin.webmailer.de
Content-Type: message/delivery-status

Reporting-MTA: dns; mailin.webmailer.de
Arrival-Date: Mon, 29 Sep 2003 19:28:17 +0200 (MEST)

Final-Recipient: RFC822; sbellon at web.de
Action: delayed
Status: 4.2.0
Last-Attempt-Date: Mon, 29 Sep 2003 23:56:49 +0200 (MEST)
Will-Retry-Until: Sat, 4 Oct 2003 19:28:17 +0200 (MEST)

--h8TL8aKu017950.1064872609/mailin.webmailer.de
Content-Type: message/rfc822

Return-Path: <relson at osagesoftware.com>
Received: from osagesoftware.com (osagesoftware.com [216.144.204.42])
	by mailin.webmailer.de (8.12.10/8.12.10) with ESMTP id h8THSHou011515
	for <sbellon at sbellon.de>; Mon, 29 Sep 2003 19:28:17 +0200 (MEST)
Received: from osage.osagesoftware.com (osage.osagesoftware.com [192.168.1.10])
	by osagesoftware.com (Postfix) with SMTP id 0730B27D86
	for <sbellon at sbellon.de>; Mon, 29 Sep 2003 13:28:15 -0400 (EDT)
Date: Mon, 29 Sep 2003 13:28:15 -0400
From: David Relson <relson at osagesoftware.com>
To: Stefan Bellon <sbellon at sbellon.de>
Subject: Re: new cvs snapshot
Message-Id: <20030929132815.173cee4e.relson at osagesoftware.com>
In-Reply-To: <4c399f61ddsbellon at sbellon.de>
References: <20030928231450.69e2022f.relson at osagesoftware.com>
	<4c3967aa3csbellon at sbellon.de>
	<20030929072209.319d4040.relson at osagesoftware.com>
	<4c399f61ddsbellon at sbellon.de>
Organization: Osage Software Systems, Inc.
X-Mailer: Sylpheed version 0.9.5claws30 (GTK+ 1.2.10; i686-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Mon, 29 Sep 2003 18:43:30 +0200
Stefan Bellon <sbellon at sbellon.de> wrote:

> But even if the order is like you did it, there's still the mistake in
> that you wrote:
> 
>     if (which == PR_ENV_BOGO)
>         dir = create_path_from_env("Bogofilter$Dir", NULL);
> 
> Whereas correct is:
> 
>     if (which == PR_NONE)
>         dir = create_path_from_env("Bogofilter$Dir", NULL);

I missed that and have fixed it.

> I changed the priorities for RISC OS in
> bogoconfig.c:process_args_and_config_file() and so that change must
> reflect here.

> 
> Do you correct the above two things (adding system_config_file to
> system.c and replacing PR_ENV_BOGO with PR_NONE) or should I send you
> the files again?


--h8TL8aKu017950.1064872609/mailin.webmailer.de--