Variable name clash

David Relson relson at osagesoftware.com
Thu Jan 8 18:58:33 CET 2004


On Thu, 08 Jan 2004 18:47:13 +0100
Stefan Bellon <sbellon at sbellon.de> wrote:

> Hi!
> 
> In bogohist.c and msgcounts.c there are the variables msgs_good and
> msgs_bad defined twice. I think it would be good programming practice,
> defining them static if not needed from another module. Or,
> alternatively, rename one pair, but having those variables exported
> with the same name might sooner or later result in some nice linker
> problems.
> 
> Greetings,
> 
> Stefan.

Stefan,

It's an unnecessary duplication.  I've deleted the declaration in
bogohist.c and all is fine.

David




More information about the bogofilter-dev mailing list