lexer changes

David Relson relson at osagesoftware.com
Wed Nov 12 01:15:39 CET 2003


On Tue, 11 Nov 2003 17:17:20 +0200
Andras Salamon <andras at dns.net> wrote:

> On Tue, Nov 11, 2003 at 02:59:01PM +0100, Boris 'pi' Piwinger wrote:
> > -ENCODED_WORD	=\?{CHARSET}\?[bq]\?[^\?]*\?\=
> > +ENCODED_WORD	=\?{CHARSET}\?[bq]\?[^?]*\?=
> 
> Personally I would prefer some of the "extra" backslashes to stay.
> The ^\? may be equivalent to ^? in the above regex, but the second
> version looks to me like the representation of ASCII DEL (0x7F). 
> Confusing.
> 
> It's great to have this level of scrutiny of the lexer, but please
> don't change stuff just to achieve some kind of "optimality".  Mortals
> like me still need to read the code.
> 
> Simplifications and clarifications of the state machine, on the other
> hand, are always useful.
> 
> -- Andras Salamon                   andras at dns.net

Andras,

Don't worry.  I've removed a few of the backslashes that pi targeted,
but most have been left in.  The ones that are present are either
necessary or benign.  They don't slow down the lexer or increase the
size of the executable.

David




More information about the bogofilter-dev mailing list