[cvs] bogofilter/src globals.c,1.34,1.35 globals.h,1.30,1.31 lexer_v3.l,1.73,1.74 collect.c,1.14,1.15 bogolexer.c,1.39,1.40

[Matthias Andree]

On Fri, 05 Sep 2003, relson at users.sourceforge.net wrote:

>   */
>  void collect_words(wordhash_t *wh)
>  {
> -    wordprop_t *w;
> +    if (setjmp(lexer_abort_jmp_buf) == 0)
> +	return;

This basically throws away error conditions...

>      while (reader_more()) {
>  	initialize();
> +
> +	if (setjmp(lexer_abort_jmp_buf) != 0)
> +	    continue;
> +

...without any macroscopic error return. What I'd like bogofilter to do
is: a. do not change any data bases unless the read + parse was entirely
successful b. report the error back and continue to exit with an error
exit code.

Am I missing something obvious about the code? Else we've just broken
bogofilter.

-- 
Matthias Andree

Encrypt your mail: my GnuPG key ID is 0x052E7D95