[bugs]Error in Graham.c line 158

[Matthias Andree]

David Relson <relson at osagesoftware.com> writes:

>>I am running BogoFilter 0.10.2 on RedHat 7.2 i386. I noticed that I seem to
>>be getting a lot of errors during the running of Bogofilter. The error
>>message is:
>>
>>Internal error in graham.c:158
>>
>>The relevant part of the code is:
>>
>>if (strlcpy(hit->key, text, MAXTOKENLEN) >= MAXTOKENLEN) {
>>     /* The lexer should not have returned a token longer than
>>      * MAXTOKENLEN */
>>     internal_error;
>>     abort();
>>}
>>
>>Any ideas would be appreciated.
>
>
> George,
>
> Can you send me a .tgz file with your bogfilter configuration, the
> command line that you run bogofilter with, and an offending message?
> Given that, I can take a look at the code and correct the problem.
>
> To be honest, the Graham algorithm is old and out of date. 

Still, we test it. The error message means nothing else than "caught
buffer overflow attempt" and tells us there is a bug.

It might be one of the infamous "NUL character costs us one byte of our
buffer" monsters though.

-- 
Matthias Andree