[cvs] bogofilter system.h,1.4,1.5

Matthias Andree matthias.andree at gmx.de
Fri Nov 22 18:26:13 CET 2002


relson at users.sourceforge.net writes:

> Index: system.h
> ===================================================================
> RCS file: /cvsroot/bogofilter/bogofilter/system.h,v
> retrieving revision 1.4
> retrieving revision 1.5
> diff -u -d -r1.4 -r1.5
> --- system.h	22 Nov 2002 12:23:15 -0000	1.4
> +++ system.h	22 Nov 2002 12:24:24 -0000	1.5
> @@ -9,12 +9,10 @@
>  
>  #if HAVE_STDBOOL_H
>  # include <stdbool.h>
> -/*
>  # undef	true
>  # undef	false
>  # define false (bool) 0
>  # define true  (bool) 1
> -*/

*shrug*

Well, the ISO C standard requires that these be defined as 0 or 1, and
_Bool is a standard unsigned integer. There is no mention of a (bool)
cast. See http://std.dkuug.dk/JTC1/SC22/WG14/www/standards

So GCC is right here with #define true 1, and all that -Wconversion
does is mentioning that we have types of different width, but our
prototypes handle that.

We should kill -Wconversion once we're sure that there is no code
defect.

-- 
Matthias Andree



More information about the bogofilter-dev mailing list