Bug#231047: Stopped tilde-expanding bogofilter_dir config file setting

[Clint Adams]

> Bogofilter 0.17.0 has stopped tilde-expanding the bogofilter_dir
> setting in the config file:
> 
> $ cat pseudotrain.cf
> min_dev=0.1
> robs=0.5
> robx=0.5
> ham_cutoff = 0.90
> spam_cutoff = 0.98
> bogofilter_dir = ~/.spamcan/mkgraph
> 
> $ bogofilter -c pseudotrain.cf
> Error creating directory '~/.spamcan/mkgraph': No such file or
> directory
> Error creating directory '~/.spamcan/mkgraph': No such file or
> directory
> Can't open file 'wordlist.db' in directory '~/.spamcan/mkgraph'.
> error #2 - No such file or directory.
> 
> Remember to register some spam and ham messages before you
> use bogofilter to evaluate mail for its probable spam status!
> $
> 
> It worked in 0.16.4. As far as I can tell, the culprit is the new
> option-processing code in bogoconfig.c, which initialized long_options
> to, among other things:
> 
>     { "bogofilter_dir",                 N, 0, 'd' },
> ...
>     { "bogofilter_dir",                 R, 0, O_BOGOFILTER_DIR },
> 
> The first of these should probably have had a dash instead of an
> underscore; it leads to code that assumes that the value has been
> passed on the command line (where the shell may be assumed to have
> done its own tilde expansion).
> 
> At least, changing it to a dash fixes the problem for me.
> 
> 
> I tried to report this directly to upstream, but by mail bounced
> because I am not subscribed to their mailing lists. (I smell irony
> here).

Plenty of other people have been bitten by this in the past.