[PATCH] non-compliant encoded text causes 0.15.3 segfault

[Matthias Andree]

David Relson <relson at osagesoftware.com> writes:

> The encoded text problem is caused by a mismatch between the lexer
> pattern and the C code.  The code expects properly formed encoded tokens
> and is failing because it's getting something else.  The NULL checks are
> a defensive mechanism, not a proper fix.

I'd rather make sure that no function can ever cause SIGSEGV on bogus
input data. Assumptions about input format will fail sooner or later,
and the bare minimum would be an assert() to ensure the requirements are
met below that point.

> I understand the frustrations of computers.  You can count on that. 
> Right now, I've got an NT box that won't see network shares (though the
> Win98 box does) and I'm also dealing with a variety of glitches in
> sylpheed-claws (which is up to 0.9.5 as of yesterday).

Entire series of books have been written on the MS "browsing"... it's
delicate and unsuitable for serious work. I'm glad I only have 2 Windows
boxen to look after and they aren't mine, so that will end some day...

-- 
Matthias Andree

Encrypt your mail: my GnuPG key ID is 0x052E7D95