hints [was: Long, folded "To:" line]

David Relson relson at osagesoftware.com
Wed Sep 3 13:09:09 CEST 2003


On 03 Sep 2003 15:53:18 +1000
michael at optusnet.com.au wrote:

> David Relson <relson at osagesoftware.com> writes:
> > On 03 Sep 2003 13:00:21 +1000
> > michael at optusnet.com.au wrote:
> > 
> > > 
> > > I confess I haven't read through the 0.15 code yet, but might it
> > > be better to leave the un-folding in the lexer? (i.e. having the
> > > lexer eat '\n\w' rather than having the mbox parser do it?
> > > 
> > > I'm thinking here that having the mbox parser do it it really a
> > > layering violation: The folding is part of the email rfc, not part
> > > of the mbox format.
> > 
> > The processing is (roughly):
> > 
> > lexer_v3.l      yylex()
> > lexer.c            yyinput()
> >                      get_decoded_line()
> >                        get_unfolded_line()
> 
> I suspect these last two should be the other way around
> at least? (on the basis on very little thought and no
> knowledge.. :).
> 
> And then leave lexer to do the unfolding and your long
> folded line problems go away....
> 

You may be right.  Possibly get_decoded_line() is named wrong.  A better
name might be get_line().  I can try the "let flex unfold" experiment
...  It might work, though I have some reservations from 'way back
(possibly unfounded).




More information about the Bogofilter mailing list