Long, folded "To:" line [was: easier bug to fix?]

michael at optusnet.com.au michael at optusnet.com.au
Wed Sep 3 00:55:43 CEST 2003


David Relson <relson at osagesoftware.com> writes:
[...]
> Jason,
> 
> The following patch prevents a very, very long unfolded line from
> overflowing the buffer.  Flex-2.5.4 uses an 8k buffer and your message's
> folded "To:" line has 9k - thus the problem.  Since the standards
> specify the line length not exceed 998 chars, this should be fine (with
> the extra addresses not being tagged as "to:userid").

Careful. Doesn't the RFC talk about the _folded_ line length
not exceeding 998 chars?

Also, might it be a good idea to add a token when we detect
non-RFC compliant email? (':LineTooLong' or something).

Michael.

> --- lexer.c	2 Sep 2003 16:19:04 -0000	1.63
> +++ lexer.c	2 Sep 2003 21:13:50 -0000
> @@ -205,6 +206,8 @@
>  		convert_eol(text, ' ');
>  	    }
>  	}
> +	if (buff->size - count < 1000)
> +	    break;
>      }
>      return count;
>  }




More information about the Bogofilter mailing list