[cvs] SF.net SVN: bogofilter:[6829] trunk/bogofilter
David Relson
relson at osagesoftware.com
Thu May 28 13:30:49 CEST 2009
On Thu, 28 May 2009 09:43:33 +0200
Matthias Andree wrote:
...[snip]...
> Hi David,
>
> Possible optimizations aside, I am not sure if the check for "only
> CR" is (a) valid, (b) will ever get called unless someone tries to
> cheat bogofilter. Look at is_eol() in bogoreader.c, it checks only LF
> and CRLF; the xfgetsln() function that is the primitive for all
> bogoreader's line reading also cares only for LF.
>
> May I therefore suggest that we drop the else-clause? I'm happy to do
> it, your permission providing.
That'll be fine!
> Please let's also avoid mixed style in parentheses and adhere to
> regular English/German writing rules for parentheses, i. e. no blanks
> on the inside.
OK -- even though it's a change from my current preferred style ...
Regards,
David
P.S. You committed a "make check" change but didn't include "t_qpcr"
and associated files.
More information about the bogofilter-dev
mailing list