[PATCH] Bug#317524: infinite loop when using charset_default=iso-8859-1

Matthias Andree matthias.andree at gmx.de
Sun Nov 6 22:18:53 CET 2005


David Relson <relson at osagesoftware.com> writes:

> Renamed the attachment so that mailman won't delete it.
>
> diff -u -r1.232 bogoconfig.c
> --- bogoconfig.c	15 Oct 2005 20:52:51 -0000	1.232
> +++ bogoconfig.c	5 Nov 2005 00:14:39 -0000
> @@ -169,6 +169,23 @@
>  static char *get_string(const char *name, const char *arg)
>  {
>      char *s = xstrdup(arg);
> +
> +    /* scan option to delete comment (after '#') and preceding whitespace */
> +    char *t = s;
> +    bool quote = false;

JFTR: Do not use this patch, it uses isspace(some char) without cast to
unsigned char (which is a bug and causes actual bellyaches on Solaris),
and it duplicates code.  David already fixed the CVS a few hours after
the original version.

If someone needs a broken-out patch, drop us a line, otherwise, you can
pull from CVS or wait for 0.96.5.

-- 
Matthias Andree



More information about the bogofilter-dev mailing list