[cvs] bogofilter/src bogoconfig.c, 1.223, 1.224 bogolexer.c, 1.87, 1.88 bogoutil.c, 1.222, 1.223

[David Relson]

On Wed, 08 Jun 2005 01:18:41 +0200
Matthias Andree wrote:

> David Relson <relson at users.sourceforge.net> writes:
> 
> > Update of /cvsroot/bogofilter/bogofilter/src
> > In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv30482
> >
> > Modified Files:
> > 	bogoconfig.c bogolexer.c bogoutil.c 
> > Log Message:
> > Add --unicode=yes/no option.
> 
> David,
> 
> we've had enough of a mess with the run-time selectable transactional
> support for Berkeley DB, please do not add another complexity bomb.
> 
> Whenever the system has iconv support with Unicode and UTF-8
> (compile-time --disable switch only), we should arrange to use it,
> EXCEPT if the database is in "RAW" format in which UTF-8 conversion is
> pointless.
> 
> This is not something we should give the users a run-time choice
> about. We wouldn't let users disable the MIME decoders either.

Matthias,

You've already mentioned your concern.  If you'd looked closely, you'd
notice that the option is only in bogolexer and bogoutil.  In bogolexer
it allows parser/iconv testing.  In bogoutil I'm thinking of linking
the switch to maintenance mode, i.e. changing what's in the database
either in place or during dump or during load.

At present bogoutil doesn't have maintenance code for converting
between raw and utf-8. So its flag doesn't do anything significant.

David