Inlining [was: [cvs] bogofilter/src score.c ]

David Relson relson at osagesoftware.com
Mon Jan 17 23:07:51 CET 2005


On Mon, 17 Jan 2005 21:33:39 +0100
Matthias Andree wrote:

> David Relson <relson at osagesoftware.com> writes:
> 
> > The thought of so elegantly combining those two functions hadn't crossed
> > my mind.
> 
> I have inlined the beast, it's effectively redundant with just one
> consumer.

Matthias,

Inlining is fine.  Reflecting on your earlier messages, I realize you're
right that a "compute" function shouldn't be responsible for calling
"lookup". Likely there _is_ an appropriate higher level place for the
lookup call.  I'll take a look when I have time.

David



More information about the bogofilter-dev mailing list