CR check in base64_decode

[David Relson]

On Tue, 04 Jan 2005 02:15:39 +0100
Matthias Andree wrote:

> David Relson <relson at osagesoftware.com> writes:
> 
> > On Mon, 03 Jan 2005 15:10:33 +0100
> > Matthias Andree wrote:
> >
> >> relson at users.sourceforge.net writes:
> >> 
> >> > Update of /cvsroot/bogofilter/bogofilter/src
> >> > In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv5697
> >> >
> >> > Modified Files:
> >> > 	base64.c 
> >> > Log Message:
> >> > Ignore both CR and LF during validation.
> >> 
> >> Why? The reader stuff is supposed to strip the CR from files in "wire
> >> format" (i. e. CRLF line ends) rather than "local format" (i. e. LF on
> >> Unix).
> >
> > I was testing with a file having CRLF pairs, and "base64_validate" was
> > returning false because it didn't like the CR.  I'll revisit the problem.
> 
> Hm. "file" of what format? mbox and Maildir store LF only, I don't know
> about the other formats offhand. At any rate, that stuff needs to be
> called from another layer anyways, not from the lexer.  A leftover
> change from last year.

Remember bogofilter runs on multiple platforms, hence must deal with CRLF pairs...
> 
> -- 
> Matthias Andree
> _______________________________________________
> Bogofilter-dev mailing list
> Bogofilter-dev at bogofilter.org
> http://www.bogofilter.org/mailman/listinfo/bogofilter-dev


-- 
David Relson                   Osage Software Systems, Inc.
relson at osagesoftware.com       Ann Arbor, MI 48103
www.osagesoftware.com          tel:  734.821.8800