[cvs] bogofilter/src datastore_olddb.c,1.3,1.4

David Relson relson at osagesoftware.com
Sat Nov 20 05:18:42 CET 2004


On Sat, 20 Nov 2004 04:45:30 +0100
Matthias Andree wrote:

> relson at users.sourceforge.net writes:
> 
> > Merge additional txn revisions.
> >
> > Index: datastore_olddb.c
> > ===================================================================
> > RCS file: /cvsroot/bogofilter/bogofilter/src/datastore_olddb.c,v
> > retrieving revision 1.3
> > retrieving revision 1.4
> > diff -u -d -r1.3 -r1.4
> > --- datastore_olddb.c	20 Nov 2004 01:21:56 -0000	1.3
> > +++ datastore_olddb.c	20 Nov 2004 01:44:10 -0000	1.4
> > @@ -59,6 +59,7 @@
> >      DB		*dbp;		/* data base handle */
> >      bool	locked;
> >      bool	is_swapped;	/* set if CPU and data base endianness differ */
> > +    DB_TXN	*txn;		/* stores the transaction handle */
> 
> This dead code doesn't belong here. I see not that we could merge
> _olddb and _db in a sensible way.

An extra element in a structure does little harm.  As you realize, I'm
looking at what sort of result would come from merging the two files. 
I don't care for the two file approach and wish to determine if
there's something better.



More information about the bogofilter-dev mailing list