[cvs] bogofilter/src bogoQDBMupgrade.c, 1.4,
David Relson
relson at osagesoftware.com
Fri Nov 19 01:03:37 CET 2004
- Previous message (by thread): [cvs] bogofilter/src bogoQDBMupgrade.c, 1.4, 1.5 bogoutil.c, 1.128, 1.129 datastore_db.c, 1.122, 1.123 find_home.test.c, 1.3, 1.4
- Next message (by thread): [cvs] bogofilter/src bogoQDBMupgrade.c, 1.4,
- Messages sorted by:
[ date ]
[ thread ]
[ subject ]
[ author ]
On Fri, 19 Nov 2004 00:56:08 +0100
Matthias Andree wrote:
> relson at users.sourceforge.net writes:
>
> > Modified Files:
> > bogoQDBMupgrade.c bogoutil.c datastore_db.c find_home.test.c
> > Log Message:
> > Use EX_ERROR instead of EXIT_FAILURE.
> >
> > Index: bogoQDBMupgrade.c
> > ===================================================================
> > RCS file: /cvsroot/bogofilter/bogofilter/src/bogoQDBMupgrade.c,v
> > retrieving revision 1.4
> > retrieving revision 1.5
> > diff -u -d -r1.4 -r1.5
> > --- bogoQDBMupgrade.c 1 Nov 2004 04:49:24 -0000 1.4
> > +++ bogoQDBMupgrade.c 18 Nov 2004 20:31:08 -0000 1.5
> > @@ -53,20 +53,20 @@
> > " If <backup> is given, <database> is backed up to <backup>
> > and\n"" upgraded in place, via <tempfile>.\n",
> > argv[0], argv[0]);
> > - exit(EXIT_FAILURE);
> > + exit(EX_ERROR);
>
> Why in this file? bogoQDBMupgrade.c isn't documented to share
> bogofilter's return values.
Shotgun approach. Be consistent. If there's a reason to use
EXIT_FAILURE, we can revert the change.
> The other patches are fine though, thank you.
>
> --
> Matthias Andree
- Previous message (by thread): [cvs] bogofilter/src bogoQDBMupgrade.c, 1.4, 1.5 bogoutil.c, 1.128, 1.129 datastore_db.c, 1.122, 1.123 find_home.test.c, 1.3, 1.4
- Next message (by thread): [cvs] bogofilter/src bogoQDBMupgrade.c, 1.4,
- Messages sorted by:
[ date ]
[ thread ]
[ subject ]
[ author ]
More information about the bogofilter-dev
mailing list