[cvs] bogofilter/src bogotune.c,1.157,1.158

[David Relson]

On Thu, 30 Sep 2004 11:20:25 +0200
Matthias Andree wrote:

> relson at users.sourceforge.net writes:
> 
> > Update of /cvsroot/bogofilter/bogofilter/src
> > In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv2403
> >
> > Modified Files:
> > 	bogotune.c 
> > Log Message:
> > Don't permit use of both '-d' and '-D' options.
> 
> Does this catch "bogotune -D -d blah"?

Good point.  No, it doesn't.  The current code also allows "-d first -d
second" and allows '-D -D', neither of which is particularly meaningful.
I could add a flag so that only one of '-D' or '-d' is allowed.
 
> What is this -D stuff *really* about?

"-D" is about not using wordlist.db when running bogotune.  With "-D"
bogotune builds a temporary (in-memory) wordlist using some of the
messages and uses the rest of the messages for the scoring tests during
the tuning process.

> Wouldn't we rather add an option so that bogotune can tell the data
> base stuff "data base in memory, no bogohome needed"? I wonder if the
> patch you made leaves all the environment stuff in still - which is
> useless for an in-memory data base which goes away with program
> shutdown.

Are you suggesting a flag for "-D is set" and testing that before
"assert(bogohome)"?  

I guess I don't understand what you want.  If using '-D', bogotune
doesn't need environment variables and ignores them.