uint [was: [cvs] base64.h ... ]

[Matthias Andree]

On Sat, 24 Jan 2004, David Relson wrote:

> On Tue, 20 Jan 2004 07:48:04 -0800
> m-a at users.sourceforge.net wrote:
> 
> > Update of /cvsroot/bogofilter/bogofilter/src
> > In directory sc8-pr-cvs1:/tmp/cvs-serv25515/src
> > 
> > Modified Files:
> > 	base64.h buff.h globals.h mime.h qp.h word.h 
> > Log Message:
> > uint -> unsigned int in headers (portability).
> 
> Matthias,
> 
> I just noticed this change and don't like it! 
> 
> Using "uint" allows declarations to line up and makes them easier to
> read.  Using "unsigned int" messes this up.  

We can just add TAB so they match again.

> "uint" has been fine for the last 18 months, why change now?  What
> platform(s) have trouble with uint?  I don't like "dumbing down" our
> code and making it hard to read in order to accommodate an unusual
> platform.

uint is a non-standard type, and we didn't include according headers
to define it before *using* this type, that used to be the problem,
which showed with various compilers in strict mode.

OTOH, I am no particular friend of "deep" includes that pull lots of
other files in, because this affects (adversely) the compilation of all
files.

We'd then need our own bftypes.h include that doesn't include anything
itself but config.h.

-- 
Matthias Andree

Encrypt your mail: my GnuPG key ID is 0x052E7D95