lexer changes

Boris 'pi' Piwinger 3.14 at logic.univie.ac.at
Tue Nov 11 18:11:38 CET 2003


Andras Salamon wrote:

>> -ENCODED_WORD	=\?{CHARSET}\?[bq]\?[^\?]*\?\=
>> +ENCODED_WORD	=\?{CHARSET}\?[bq]\?[^?]*\?=
> 
> Personally I would prefer some of the "extra" backslashes to stay.
> The ^\? may be equivalent to ^? in the above regex, but the second version
> looks to me like the representation of ASCII DEL (0x7F).  Confusing.
> 
> It's great to have this level of scrutiny of the lexer, but please don't
> change stuff just to achieve some kind of "optimality".  Mortals like
> me still need to read the code.

That's why I did it. I couldn't read the code with all those
escaping for totally unclear (actually no) reasons.

pi





More information about the bogofilter-dev mailing list