Experience with 0.15.2

David Relson relson at osagesoftware.com
Mon Sep 8 19:29:37 CEST 2003


On Mon, 08 Sep 2003 18:54:29 +0200
Matthias Andree <matthias.andree at gmx.de> wrote:

> David Relson <relson at osagesoftware.com> writes:

> > @@ -210,7 +210,7 @@
> >      if (datestamp_tokens || today != 0)
> >  	val->date = today;
> >  
> > -    for (dsh->index = 0; dsh->index < dsh->count; (int)dsh->index
> > += 1) {+    for (dsh->index = 0; dsh->index < dsh->count;
> > dsh->index++) {
> >  
> >  	/* With two wordlists, it's necessary to check index and
> >  	** run_type to avoid writing all tokens to both lists. */
> 
> The problem is with the data type. We're happily increasing an enum
> that is abused as an int, and I got entangled in the subtle
> differences in the C ./. C++ cast semantics. We'd better make the
> dsh->index an int to end this story.

I don't foresee any problems with int.  I'll take care of it.




More information about the bogofilter-dev mailing list