Experience with 0.15.2

David Relson relson at osagesoftware.com
Mon Sep 8 00:55:19 CEST 2003


On Mon, 08 Sep 2003 00:14:53 +0200
Stefan Bellon <sbellon at sbellon.de> wrote:

> David Relson wrote:
> > On Sun, 07 Sep 2003 22:34:34 +0200
> > Stefan Bellon <sbellon at sbellon.de> wrote:
> 
> > > 1) In src/datastore.c two casts have been introduced in the loops
> > >    in line 157 and line 213. I get the following errors:
> > > 
> > >       "c.datastore", line 157: Error: objects that have been cast
> > >       are not l-values
> > >       "c.datastore", line 213: Error: objects that have been cast
> > >       are not l-values
> 
> > Attached is an alternate construct.  Let me know how well it works.
> 
> Yes, it's fine now.
> 
> > > 2) Matthias re-worked my QDBM code and replaced the Relic API with
> > >    the Depot API. First of all, this makes a few includes that are
> > >    still present in the code superfluous, but second and worse,
> > >    it's a lot slower as the Relic API does some optimization for
> > >    you that you have to do by your own if you use the Depot API. I
> > >    have added those things now. See attached patch for
> > >    src/datastore_qdbm.c.
> 
> > Which just shows the combined knowledge of two people is more than
> > the individual knowledge. 
> 
> That's why Free Software works so well. :-)
> 
> > Your patch has been added to bogofilter and committed to CVS.  I've
> > also attached a copy of the file so you can check my work.
> 
> Yes, looks good.
> 
> > > 3) And finally, I have a message that crashes the lexer of 0.15.2
> > >    whereas the lexers in the previous versions were able to cope
> > >    with it. The file in question is attached as well. Here's the
> > >    stack backtrace:
> [snip]
> > >       Termination signal received: Segmentation fault
> 
> > Happens here too.  The relevant code has been rewritten so that
> > whitespace separated encoded tokens will be joined, i.e.
> > "=?charset?Q?ok?= =?charset?Q?ay?=" will be interpreted as "okay". 
> > I'm looking at the code and will have it fixed shortly.
> 
> Nice. :-)

Stefan,

It's the old two step -- one step backward, two steps forward.

David

David Relson                   Osage Software Systems, Inc.
relson at osagesoftware.com       Ann Arbor, MI 48103
www.osagesoftware.com          tel:  734.821.8800




More information about the bogofilter-dev mailing list