[cvs] bogofilter/src xatof.c,1.1,1.2 xatoi.c,1.1,1.2 xatox.h,1.1,1.2

Greg Louis glouis at dynamicro.on.ca
Fri Feb 28 12:32:02 CET 2003


On 20030227 (Thu) at 2129:52 -0500, David Relson wrote:
> Matthias,
> 
> I patched the xato?.c routines so that they could accept an unmodified copy 
> of bogofilter.cf.example as the config file.  I specifically wanted lines 
> like the following allowed:
> 
> spam_cutoff = 0.90f # for graham
> spam_cutoff = 0.54f # for robinson

But why, is the question?  spam_cutoff's a double; why feed it a float
value (that gets converted anyway)?  (I've been wondering for months
about all those f's scattered through the code, but I've been too lazy
to rauss them systematically.)  I suppose, just to be friendly to non-C
types, one could accept and ignore f in config files -- but non-C types
wouldn't expect to put f at the end of a number anyhow.

-- 
| G r e g  L o u i s          | gpg public key: finger     |
|   http://www.bgl.nu/~glouis |   glouis at consultronics.com |
| Help free our mailboxes. Include                         |
|              http://wecanstopspam.org in your signature. |




More information about the bogofilter-dev mailing list