[cvs] bogofilter/tests/bogofilter t.grftest,1.6,1.7

David Relson relson at osagesoftware.com
Thu Jan 30 00:17:07 CET 2003


At 05:29 PM 1/29/03, Matthias Andree wrote:

>relson at users.sourceforge.net writes:
>
> > Update of /cvsroot/bogofilter/bogofilter/tests/bogofilter
> > In directory sc8-pr-cvs1:/tmp/cvs-serv2030/bogofilter
> >
> > Modified Files:
> >       t.grftest
> > Log Message:
> > Fix broken tests.
>
>What was broken about that test?

I thought t.grftest was broken because there was no grftest.20030129 after 
running it.  Thinking about it now, the problem probably may have been that 
t.save was checking the wrong environment variable.

On the cosmic scale, t.grftest failed to detect the missing msgcount in 
graham.c - the problem that Clint encounterd as a SIGFPE.  My guess is 
that, with all the parser changes, I didn't check closely enough to see 
_why_ the reference results needed to be updated.  Anyhow for versions 
0.10.0 through 0.10.1.2 t.grftest and t.systest are validating a busted 
graham algorithm.  After hearing from Clint and Allyn, it'll be time to 
decide whether to build/release 0.10.1.3 tonight or wait for additional 
fixes.  Let me know if you have strong feelings one way or the other.

David





More information about the bogofilter-dev mailing list