datastore.h

Matthias Andree matthias.andree at gmx.de
Wed Jan 8 17:30:09 CET 2003


David Relson <relson at osagesoftware.com> writes:

>>Unless there's some compelling reason not to, I'd like to combine the
>>two files...
>
> Looking at datastore_db.h, it seems to mix datastore dependent and
> datastore independent info.  Certainly, dbv_t and db_setvalue_and_date()
> are independent.  dbh_t looks dependent with its use of DB.  pid,
> locked, and is_swapped also look dependent.
>
> If you move the dbv_t and db_setvalue_and_date declarations to
> datastore.h, then I suspect there should be very few files that know
> about datastore_db.h

Dependent stuff that is never used outside datastore_db.[ch] can just as
well be moved into datastore_db.c. The datastore independent info
however should move into datastore.h, of course.

-- 
Matthias Andree




More information about the bogofilter-dev mailing list