patches from sourceforge

[Matthias Andree]

David Relson <relson at osagesoftware.com> writes:

> Matthias,
>
> The attached patches were contributed through sourceforge.
>
> I'm inclined to accept the savetofile patch, which is short, sweet, and
> clean.   If I don't hear to the contrary, I'll add it tomorrow or
> Saturday.

There's a minor inconsistency, we arrange for PATH_MAX + 100 storage and
limit strlcpy to 100. I'll merge a cleaned up version in a few moments.

>   The lexer patch is more complex and likely conflicts with your current
> work on attachments.  There may be parts of it that are useful, so I'll
> let you decide what to do.

It'll need some review I'm not able to do before Sunday. It uses some
modifications to the flexer state machine I don't yet overlook, and it
might also need benchmarks. The MIME BOUNDARY stuff needs rework, the
BASE64 patch OTOH is clean. It's probably emacs + ediff + diff3 time. :-)

> -MIME_BOUNDARY	^--[^[:blank:][:cntrl:]]+
> +MIME_BOUNDARY	^--[ A-Za-z0-9'()+_,./:=?-]*[A-Za-z0-9'()+_,./:=?-]

I have a similar thing that uses the official RFC-2045ff words ;-)

> +valign	|
> +value	|

And we'll use a case insensitive lexer instead if necessary. I'm not
adding the same stuff twice only to let it slip when someone types
vAlIgN (which is a valid HTML tag)

> diff -u config.c config.c
> --- config.c	2002-12-05 18:20:37.000000000 +0100
> +++ config.c	2002-12-08 19:06:52.370339000 +0100
> @@ -66,6 +66,8 @@
>  static bool suppress_config_file = false;
>  
>  char directory[PATH_LEN + 100] = "";
> +char outfname[PATH_LEN + 100] = "";
                |
^ doesn't match v
|

> +        case 'O':
> +            strlcpy(outfname, optarg, PATH_LEN);
> +

and this does not barf on overruns.

-- 
Matthias Andree