[cvs] bogofilter common.h,1.27,1.28 config.c,1.81,1.82

Matthias Andree matthias.andree at gmx.de
Fri Dec 13 01:50:52 CET 2002


relson at users.sourceforge.net writes:

> Update of /cvsroot/bogofilter/bogofilter
> In directory sc8-pr-cvs1:/tmp/cvs-serv632
>
> Modified Files:
> 	common.h config.c 
> Log Message:
> Option '-R' sets the default algorithm, if the current algorithm isn't
> robinson or fisher and the default is robinson or fisher.

I was wondering if we could get rid of 90% of these #ifdefs by always
providing the algorithm documentation and parser and if we were just to
replace the disabled algorithms with a stub that says "you did not
compile support for this algorithm into bogofilter"; the only places
we'd need the #ifdefs are then the algorithm (to choose: real
implementation or stub) and the default algorithm selection.

We're adding tons of #ifdefs for conditional compilations when the
savings are minor. We're not getting rid of a single line in lexer.l
that way, and lexer.o is our bloatware module in the binaries, so we're
optimizing the wrong end actually.

-- 
Matthias Andree




More information about the bogofilter-dev mailing list