[cvs] bogofilter format.c,1.8,1.9

Matthias Andree matthias.andree at gmx.de
Thu Dec 5 01:45:45 CET 2002


relson at users.sourceforge.net writes:

> --- format.c	2 Dec 2002 20:42:11 -0000	1.8
> +++ format.c	4 Dec 2002 15:43:10 -0000	1.9
> @@ -181,10 +181,7 @@
>      if (flags & F_PREC && prec < len)
>  	len = prec;
>      if (dest + len + 1 < destend) {
> -	/* warning: this is abuse of strlcpy. we can do this because we
> -	 * checked.
> -	 */
> -	strlcpy(dest, src, len + 1);
> +	memcpy(dest, src, len + 1);
>      } else {
>  	fprintf(stderr, "header format is too long.\n");
>  	/* abort to obtain a stack backtrace */

This breaks when prec < strlen(src).

Correct code is:

memcpy(dest, src, len);
dest[len] = '\0';

Now in CVS,  format.c:1.10.

-- 
Matthias Andree




More information about the bogofilter-dev mailing list