[cvs] bogofilter/contrib bogopass,1.3,1.4

[Allyn Fratkin]

Matthias Andree wrote:
> I was wondering if we
> should do basic tests for contrib/* programs or if we should rather
> spend our time on something else, because it's explicitly marked
> interim solution.

i feel like contrib scripts should do what they are intended on at least
some boxes but don't need rigorous cross-platform testing and don't
need automatic configuration.

> Should we figure the Perl path at configure time then and create these
> scripts with config.status?

too much trouble.  easier just to call attention to the need to hand-edit in
a README file.  most anybody setting up bogofilter at this point is
going to need some skill and doesn't need excessive handholding.

>>>We must not close the file handle yet, unlink0 needs it below.
>>
>>unlink0 worked fine even if $fh was closed.
>  
> "not here", it printed two lines on stderr about stat'ing a closed $fh.

interesting, no message on redhat 8 and the file was removed correctly.
ok, i'm convinced.

> The whole point about bogopass is to emulate "bogofilter -p" with
> unbase64, so we don't want "cat" in there.

certainly true.

> I believe the way File::Temp deals with it is safe enough. If we're
> paranoid, we enforce that /tmp has its sticky bit set (so that files can
> only be deleted by their respective owners) and bail out if it's unset,
> or use a private .tmp file.

perhaps a private ~/.bogopass.XXXXXXXX would be better?  most people
don't have writeable home directories.  i DON'T think we should be
trying to tell administrators (or worse, users) that they should change
their /tmp permissions just to use bogopass.

> Seriously, I think we should only fix the remaining /usr/bin/env versus
> $PATH consistency issues and keep it the way it is.

ok, i'm fine with deleting the PATH setting and using "/usr/bin/env perl"
to find perl.  or explicitly setting the perl path and using searching the
incoming PATH for unbase64 and bogofilter.  or hardcoding all paths.
the only variation i'm really against is "/usr/bin/env perl" followed
by explicit PATH setting.

i've made some final changes to bogopass (matthias, your latest change
was passing back the corrupted unbase64-ed message again), and i am
fine the way it is now.  i also deleted the explicit PATH setting
since matthias had put back the "/usr/bin/env perl".

i think it is ok to ship.  matthias, do you agree?
-- 
Allyn Fratkin             allyn at fratkin.com
Escondido, CA             http://www.fratkin.com/