subtle "algorithm" definition issue.

[Matthias Andree]

David Relson <relson at osagesoftware.com> writes:

>>setup_lists does not need the algorithm. It's only ever called from
>>main.c, and I have main.c now pass in the good/bad weights, with the
>>latter fixed to 1.0 and the former to whatever GOOD_BIAS expands to. (We
>>might consider making GOOD_BIAS a function though.)
>
> bogofilter.c includes init_constants(), which is the function that knows
> the Robinson/Graham differences for constants used during calculating
> spamicity.  I think that good_bias should be set there.  If we want to
> be object oriented, let's add accessor functions get_spam_bias() and
> get_good_bias() to bogofilter.c and let setup_lists() use them.

Sounds reasonable.

> read_config_file() in config.c and by process_args() in main.c).  Since
> these routines deal with configuration and execution parameters, it
> might be a good idea to have them in the same module.

Yes, it is a good idea. (Because you speak of "module"s.)

-- 
Matthias Andree