[PATCH] Three fixes against current CVS

[Adrian Otto]

Matthais,

I've added you as a developer to the bogofilter Sourceforge project. You can
commit to CVS now.

Thanks,

Adrian

> -----Original Message-----
> From: Matthias Andree [mailto:matthias.andree at stud.uni-dortmund.de]
> Sent: Monday, September 16, 2002 6:01 AM
> To: bogofilter mailing list
> Cc: Eric S. Raymond
> Subject: [PATCH] Three fixes against current CVS
>
>
> Hi,
>
> I have three patches to bogofilter's current CVS version, and I herewith
> officially apply for CVS write access, my sourceforge login is "m-a".
>
> I can check these in myself as I get CVS access.
>
>  bogofilter.1 |    6 ++++--
>  lexer_l.l    |   17 +++++++++--------
>  main.c       |   13 +++++--------
>  3 files changed, 18 insertions(+), 18 deletions(-)
>
> Patches #1 and #2 are a /must/, #3 is optional but recommended.
>
> Please review and comment.
>
> #1  #####  fix-bogofilter-CVS-man.diff
> The bogofilter.1 patch updates the man page to show h/H instead of n/N.
>
>
> #2  #####  fix-bogofilter-CVS-boguslastline.diff
> The lexer_l.l patch corrects a subtle "last line duplication" bug, on my
> computer, the last line of the mail is sometimes duplicate but with all
> characters converted to lower case. It turns out that the yyinput()
> function does not parse the fgets() results properly.
>
> To reproduce this, I used (all on the same line):
>
> echo -e 'From: Matthias Andree <matthias.andree at udo.edu>\nDate:
> Mon, 16 Sep 2002 14:19:14 +0200\n\n-- Matthias' | ltrace -efgets
> ./bogofilter -p
>
> (you can safely omit the ltrace -efgets should your system lack ltrace
> or sotrace or something).
>
>
> #3  #####  fix-bogofilter-CVS-headerordering.diff
> The main.c patch drops adding the Spam header to the Subject and changes
> the 'p' option parser to not increment but rather assign 1 (adding more
> than one p argument does not change anything).
>
> Letting go of the Subject: ordering may look as nit-picking, but:
>
> a- it serves no purpose
> b- it is executed in a very tight loop, wasting time with expensive
>    string comparisons, slowing down bogofilter -p mode
> c- less lines of code => less bugs. Ahem, sort of at least ;-)
>
> The patches are attached to remove mail body clutter.
>
> --
> Matthias Andree
>


For summay digest subscription: bogofilter-digest-subscribe at aotto.com